Re: patch to drivers/net/8390.c

Krzysztof G. Baranowski (kgb@manjak.knm.org.pl)
Mon, 30 Nov 1998 22:21:16 +0100 (EET)

On 30 Nov 1998, Jes Sorensen wrote:
> Mikael> 2.1.130 (actually one of the pre-patches) added an unused
> Mikael> local variable "ei_local" to
> Mikael> drivers/net/8390.c:NS8390_trigger_send(). Since the variable
> Mikael> is unused (proof by compilation on x86/UP), I'm assuming this
> Mikael> was a mistake. If so, please apply the included patch.
> And this is wrong!
> The variable is needed for machines which have the registers for the
> 8390 memory mapped!
So there should be a comment explaining this.

Regards,
Kris

-- 
Krzysztof G. Baranowski - President of the Harmless Manyacs' Club
"Smith & Wesson - The original point and click interface..."
http://www.knm.org.pl/                 <prezes@manjak.knm.org.pl>




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/