Linux-kernel mailing list archive 1999-23,: Re: nfsv3 & 2.2.9 breaks smbfs (was: Re: smbfs broken in 2.2.9)

# Re: nfsv3 & 2.2.9 breaks smbfs (was: Re: smbfs broken in 2.2.9)

Steven N. Hirsch (shirsch@adelphia.net)
Mon, 7 Jun 1999 21:56:09 -0400 (EDT)

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Steven N. Hirsch: "Re: NFS bug in 2.2.9-ac? found (was Re: Kernel Panic: 2.2.9-ac1)"
- Previous message: Richard Gooch: "Re: Migrating to larger numbers"

On Mon, 7 Jun 1999, Trond Myklebust wrote:

> >>>>> " " == Urban Widmark <urban@svenskatest.se> writes:
>
> > Trond & Steven, I don't have a patch, but here is what I had to
> > change to stop the blocking.
>
> > Change smb_updatepage in fs/smbfs/file.c; add a
> > int result;
> > and change the return from
> > return smb_writepage_sync(dentry, page, offset, count);
> > to
> > result = smb_writepage_sync(dentry, page, offset,
> > count); smb_unlock_page(page); return result;
>
> > to smb_updatepage in fs/smbfs/file.c.
>
> > This also explains why plain 2.2.9 works fine.
>
> Oops. Looks like the call to smb_unlock_page that used to be in
> smb_writepage_sync itself has been removed from the stock kernel since
> last I looked. Your fix is quite correct.

Thanks! This took care of the problem. For the less adventurous, here's
the patch (works against 2.2.9-ac3 also):

--- linux/fs/smbfs/file.c.orig Mon Jun 7 18:42:14 1999
+++ linux/fs/smbfs/file.c Mon Jun 7 18:41:41 1999
@@ -198,6 +198,7 @@
static int
smb_updatepage(struct file *file, struct page *page, const char *buf, unsigned long offset, unsigned int count, int sync)
{
+ int result;
struct dentry *dentry = file->f_dentry;
set_bit(PG_locked, &page->flags);
@@ -212,7 +213,9 @@
return -EFAULT;
}
- return smb_writepage_sync(dentry, page, offset, count);
+ result = smb_writepage_sync(dentry, page, offset, count);
+ smb_unlock_page(page);
+ return result;
}
static ssize_t

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

- Next message: Steven N. Hirsch: "Re: NFS bug in 2.2.9-ac? found (was Re: Kernel Panic: 2.2.9-ac1)"
- Previous message: Richard Gooch: "Re: Migrating to larger numbers"