Re: [PATCH] VIA 82c586 ACPI support (VP2, VP3, MVP3)

[Jeff Garzik]

On Mon, 10 Jan 2000, Andrey Panin wrote:
> This small patch adds support for VIA 82c586 ACPI device.
> It is usefull for motherboards with VIA chipsets but without ACPI tables (like
> my FIC PA-2012).
> 
> This patch was tested on my machine and seems working (C2, C3 states, software
> power-down).
> 
> Any feedback will be greatly appreciated.

Looks great, and thanks for copying it to the linux-via list.

Would you consider using the PCI probe mechanism (see pci_simple_probe
in include/linux/pci.h and drivers/pci/helper.c) to simplify the code a
bit more?

Regards,

	Jeff