Re: i2o_core.c question

[=?iso-8859-1?Q?Taneli_V=E4h=E4kangas?=]

On Mon, 10 Jan 2000, Tim Waugh wrote:

> In i2o_activate_controller, what's up with this?  Is it a typo, or is it
> supposed to be like that?  It's at line 1490. (It _looks_ like a typo,
> but..)
> 
> 		if(i2o_init_outbound_q(c));
> 		I2O_REPLY_WRITE32(c,virt_to_phys(msg));
> 
> Tim.
> */

We already fixed this in 2.3.39, i2o_sys_init clean-ups thanks to Auvo.

BTW, we'd like to know if there are people actually _using_ the i2o stuff,
especially the lan part. It isn't quite ready yet, but if you have extra
i2o hardware lying around (yeah, most probable), could you please give it
a whirl? Oh, btw, it blows up quite nicely on smp ... and you need
something like this:

***snip***
--- i2o_core.c-000111   Tue Jan 11 13:30:01 2000
+++ i2o_core.c  Tue Jan 11 19:19:56 2000
@@ -2463,7 +2466,7 @@
 #endif
 
        if(i2o_num_controllers)
-               i2o_init();
+               i2o_sys_init();
 
        i2o_config_init();
 #ifdef CONFIG_I2O_BLOCK
***snip***

to even try it non-modular.

	Taneli <[e-mail]>