Re: request_module rehash

[Keith Owens]

On Thu, 13 Jan 2000 14:49:52 -0500, 
James Manning <[e-mail]> wrote:
>I was thinking about the cases where request_module's return
>isn't checked... isn't this broken code and the calling code
>should be checking < 0 and return'ing -ENODEV (or similar)?

In most (all?) cases, the code checks a field that the module fills in.
This field indicates not only that the module was loaded but that it
did its work.  Like this code from drivers/block/md.c.

  if (!pers[pnum]) {
    request_module("md-personality-%d", pnum);
    if (!pers[pnum])
       return -EINVAL;
  }