Re: ISA PnP (again) + [PATCH]

[Peter Denison]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to [e-mail] for more info.

---1734427118-1524180277-947892172=:4093
Content-Type: TEXT/PLAIN; charset=US-ASCII

Bruce J.A. Nourish wrote:
> ISA PnP seems to be working as a module in 2.3.39, in so far as is loads
> ok:
> 
> Jan 14 16:17:28 marvin kernel: isapnp: Scanning for Pnp cards...
> Jan 14 16:17:28 marvin kernel: isapnp: Card 'OPL3-SA3 Sound'
> Jan 14 16:17:28 marvin kernel: isapnp: 1 Plug & Play card detected total
> 
> But when i try to configure my card for use, using /proc/isapnp, cat
> segfaults and I get an oops. This is the related part of my rc.modules:
> 
> # Sound conf
> cat >> /proc/isapnp <<EOF
> card 0 YMH0800
> dev 0 YMH0021
[snip]
> EOF
> 
> This is the oops, passed thru ksymoops:
> Oops: 0000
> CPU:    0
> EIP:    0010:[<c480ca7a>]
> EFLAGS: 00010246
> eax: 00000000   ebx: a8652100   ecx: c1173008   edx: c114bea0
[snip]
> >>EIP; c480ca7a <[isa-pnp]isapnp_find_dev+6e/cc>   <=====
> Trace; c480f6c5 <[isa-pnp]isapnp_set_device+51/cc>
> Trace; c481093c <[isa-pnp]isapnp_info_write+a6c/217c>
[snip]
> Code;  c480ca7a <[isa-pnp]isapnp_find_dev+6e/cc>   <=====
>    0:   39 50 10                  cmpl   %edx,0x10(%eax)   <=====
> Code;  c480ca7d <[isa-pnp]isapnp_find_dev+71/cc>
>    3:   74 19                     je     1e <_EIP+0x1e> c480ca98 <[isa-pnp]isapnp_find_dev+8c/cc>

	This bug was introduced in 2.3.37, when the ISAPnP driver moved to
list_head structures. The included patch should fix it. isapnp_find_dev()
is called from isapnp_set_device() with from == NULL.

	The second chunk of the patch is subject to a disagreement
between me and Martin Mares. I think it should be in for completeness, and
so that uninitialised data structures aren't left lying around. Martin
thinks it shouldn't be in since dev->children has no meaning for ISAPnP
cards. You pays your money and takes your choice. Leave it in or out as
you see fit, it won't bite anyone (yet ;-)).

-- 
Peter Denison <[e-mail]>
Linux Driver for Promise DC4030VL cards.
See http://www.pnd-pc.demon.co.uk/promise/promise.html for details

---1734427118-1524180277-947892172=:4093
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="2.3.39-isapnp.fix"
Content-Transfer-Encoding: BASE64
Content-ID: <[e-mail]>
Content-Description: 
Content-Disposition: attachment; filename="2.3.39-isapnp.fix"

LS0tIGRyaXZlcnMvcG5wL2lzYXBucC5jLm9sZAlUdWUgSmFuIDExIDIyOjQw
OjI1IDIwMDANCisrKyBkcml2ZXJzL3BucC9pc2FwbnAuYwlGcmkgSmFuIDE0
IDIyOjU3OjMyIDIwMDANCkBAIC0xOCw3ICsxOCw3IEBADQogICogICBGb3Vu
ZGF0aW9uLCBJbmMuLCA2NzUgTWFzcyBBdmUsIENhbWJyaWRnZSwgTUEgMDIx
MzksIFVTQS4NCiAgKg0KICAqICBDaGFuZ2Vsb2c6DQotICogIDIwMDAtMDEt
MDEJQWRkZWQgSVNBUG5QIHF1aXJrcyBoYW5kbGluZw0KKyAqICAyMDAwLTAx
LTAxCUFkZGVkIHF1aXJrcyBoYW5kbGluZyBmb3IgYnVnZ3kgaGFyZHdhcmUN
CiAgKgkJUGV0ZXIgRGVuaXNvbiA8cGV0ZXJkQHBuZC1wYy5kZW1vbi5jby51
az4NCiAgKi8NCiANCkBAIC05ODQsNiArOTg0LDcgQEANCiAJCWNhcmQtPmRl
dmljZSA9IChoZWFkZXJbM10gPDwgOCkgfCBoZWFkZXJbMl07DQogCQljYXJk
LT5zZXJpYWwgPSAoaGVhZGVyWzddIDw8IDI0KSB8IChoZWFkZXJbNl0gPDwg
MTYpIHwgKGhlYWRlcls1XSA8PCA4KSB8IGhlYWRlcls0XTsNCiAJCWlzYXBu
cF9jaGVja3N1bV92YWx1ZSA9IDB4MDA7DQorCQlJTklUX0xJU1RfSEVBRCgm
Y2FyZC0+Y2hpbGRyZW4pOw0KIAkJSU5JVF9MSVNUX0hFQUQoJmNhcmQtPmRl
dmljZXMpOw0KIAkJaXNhcG5wX3BhcnNlX3Jlc291cmNlX21hcChjYXJkKTsN
CiAJCWlmIChpc2FwbnBfY2hlY2tzdW1fdmFsdWUgIT0gMHgwMCkNCkBAIC0x
MTg1LDEwICsxMTg2LDExIEBADQogCQlzdHJ1Y3QgbGlzdF9oZWFkICpsaXN0
Ow0KIA0KIAkJbGlzdCA9IGNhcmQtPmRldmljZXMubmV4dDsNCi0JCWlmIChm
cm9tKQ0KKwkJaWYgKGZyb20pIHsNCiAJCQlsaXN0ID0gZnJvbS0+YnVzX2xp
c3QubmV4dDsNCi0JCWlmIChmcm9tLT5idXMgIT0gY2FyZCkJLyogc29tZXRo
aW5nIGlzIHdyb25nICovDQotCQkJcmV0dXJuIE5VTEw7DQorCQkJaWYgKGZy
b20tPmJ1cyAhPSBjYXJkKQkvKiBzb21ldGhpbmcgaXMgd3JvbmcgKi8NCisJ
CQkJcmV0dXJuIE5VTEw7DQorCQl9DQogCQl3aGlsZSAobGlzdCAhPSAmY2Fy
ZC0+ZGV2aWNlcykgew0KIAkJCWludCBpZHg7DQogCQkJc3RydWN0IHBjaV9k
ZXYgKmRldiA9IHBjaV9kZXZfYihsaXN0KTsNCg==
---1734427118-1524180277-947892172=:4093--