Linux-kernel mailing list archive 2000-06,: Re: [PATCH] isa_{read,write}{w,l} fixed

# Re: [PATCH] isa_{read,write}{w,l} fixed

Alan Cox (alan@lxorguk.ukuu.org.uk)
Thu, 10 Feb 2000 21:40:57 +0000 (GMT)

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Richard Gooch: "Re: [PATCH] devfs v99.11 available"
- Previous message: Alan Cox: "Re: Linux Hardware Absctraction"
- Next in thread: Philipp Rumpf: "Re: [PATCH] isa_{read,write}{w,l} fixed"
- Reply: Philipp Rumpf: "Re: [PATCH] isa_{read,write}{w,l} fixed"

> In trying to fix some ISA access in older net drivers, I came across lots
> of "invalid operand to binary +" messages, tracked down to trying to add
> pointers of different types together. Since it is intuitive to pass a
> long * to isa_writel, etc. the included patch should sort this out.
>
> I can't believe it's not bitten anyone before! Does no-one use isa_writel?

I do. And the patch is wrong. Physical addresses are unsigned long. Take the
errors as a chance to fix up the types in the driver.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

- Next message: Richard Gooch: "Re: [PATCH] devfs v99.11 available"
- Previous message: Alan Cox: "Re: Linux Hardware Absctraction"
- Next in thread: Philipp Rumpf: "Re: [PATCH] isa_{read,write}{w,l} fixed"
- Reply: Philipp Rumpf: "Re: [PATCH] isa_{read,write}{w,l} fixed"