What to do with 3c59x.c?

Andrew Morton (andrewm@uow.edu.au)
Tue, 11 Apr 2000 01:05:47 +0000


I have pretty much completed the 2.3.99 merge of drivers/net/3c59x.c and
drivers/net/pcmcia/3c575_cb.c.

This driver now supports

3c59x series
3c90x series
3c980 series
3c555 series
3c575 series (Cardbus).

That's EISA, PCI and Cardbus all in the one driver. Fairly cleanly.

I wish to get a patch out for some testing. (As it claims to support 27
different NICs it's gonna need some...)

My question is: how should this driver be integrated into the kernel
tree?

- putting it in drivers/net/3c59x.c and removing
drivers/net/pcmcia/3c575_cb.c will break existing /etc/pcmcia/config
settings.

- putting it in drivers/net/pcmcia/3c575_cb.c and removing 3c59x.c will
require non-cardbus users to dive down into the "PCMCIA network device
support" configuration menu to enable the driver for their EISA or PCI
NICs. Will also break existing conf.moduleses.

- overwriting both drivers/net/3c59x.c and drivers/net/pcmcia/3c575_cb.c
with the same file is obnoxious.

- perhaps make a clean break. Put it in drivers/net/3cxxx.c and remove
the other two.

Any suggestions?

-- 
-akpm-

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/