Re: [patch] repost of netfilter/NIPQUAD patches

[Linus Torvalds]

In article <[e-mail]>,
Olaf Titz  <[e-mail]> wrote:
>> How about changing printk() so it knows how to output ipv4 dotted quads?
>
>Either that, or make a kernel version of inet_ntoa().
>I'm already using the latter approach in CIPE:

Don't people ever learn?

We used to have inet_ntoa(). We got rid of the horrible crap, because it
is neither thread-safe nor even able to be used multiple times for
printk except with ugly hacks like yours.

What's the advantage of using %s + inet_ntoa() when compared to using
the very straightforward %u.%u.%u.%u + NIP_QUAD()? There is none.

		Linus