Re: (reiserfs) Re: New Linux 2.5 - 2.6 TODO (Alan Cox suggestsdelaying

[Stephen C. Tweedie]

Hi,

On Sat, Jun 17, 2000 at 05:40:15AM -0700, Hans Reiser wrote:

> There is a guy who wrote an online resizer for ext2.  I have no idea whether it
> is good or trash. 
> He has been trying to get it into the kernel since early or mid 2.3.  Alan Cox
> is being quite helpful to the guy.  The problem is that the reasonable thing to
> do is to have one of the ext2 maintainers review his code and verify that they
> are comfortable with it and it is good code.  Why is this a problem?  Well it
> seems that the maintainers are busy with attending conferences and their own
> code right now.  They have been busy like this for more than 6 months

Odd that the last time I reviewed this code was April 17th, when Alan
first passed me a copy.  "6 months"?  Where did that figure come from?

> , and as a
> result this rather useful sounding functionality is very likely to miss 2.4. 

I'd prefer this patch to be an early 2.5 inclusion than a 2.4 feature,
since we were already _well_ into codefreeze before I ever saw the
proposed ext2 changes.  Online ext2 resizing is important, but I'd
rather see any core ext2 changes get a _lot_ of testing before a major
release, and certainly we'd need good reason to restructure such
critical code during codefreeze.

> They haven't any idea whether it is good code or not, they haven't bothered to
> read it for 6 months. 

Patently not true (I can show you the emails if you want).

> Now you guys can go ahead and hate me all you want for holding up a mirror to
> your faces, but I say that as a community there are areas we need to improve.

You said it.

Cheers,
 Stephen