Re: [PATCH] rivafb bugfixes

[Jeff Garzik]

Bakonyi Ferenc wrote:
> 
>         Hi there!
> 
> This patch fixes the following issues:
> - scrolling is very slow (by default)
> - 'shifted screen' bug
> - 'dark console' bug (I hope it works on TNTs too.)
> - unnecessary compilation warnings
> - minor cleanups
> 
> Tested on Asus V3000 Riva 128. Please test on Riva TNTs!
> 
> Greetings:
>         Ferenc Bakonyi
> 
>   ------------------------------------------------------------------------
> --- linux/drivers/video/riva/fbdev.c.ori        Wed Jun 28 16:51:41 2000
> +++ linux/drivers/video/riva/fbdev.c    Wed Jun 28 16:51:41 2000
> @@ -20,7 +20,7 @@
>   */
> 
>  /* version number of this driver */
> -#define RIVAFB_VERSION "0.7.1"
> +#define RIVAFB_VERSION "0.7.2"
> 
>  #include <linux/config.h>
>  #include <linux/module.h>
> @@ -208,10 +208,10 @@
>  static struct rivafb_info *riva_boards = NULL;
> 
>  /* command line data, set in rivafb_setup() */
> -static char fontname[40] __initdata;
> +static char fontname[40] __initdata = { 0 };
>  #ifndef MODULE
> -static char noaccel __initdata;        /* unused */
> -static const char *mode_option __initdata;
> +static char noaccel __initdata = 0;    /* unused */
> +static const char *mode_option __initdata = NULL;
>  #endif

Looks ok except for one small thing:  do not explicitly initialize these
to zero, they are automatically zeroed.  If not, it is a bug...

If TNT owners report success I will apply.

	Jeff

-- 
Jeff Garzik              |
Building 1024            | Make my funk the p-funk.
MandrakeSoft, Inc.       |