Re: Linux 2.4.0-test2-ac2

[Henrik =?ISO-8859-1?Q?St=F8rner?=]

In <[e-mail]> Alan Cox <[e-mail]> writes:

>2.4.0test2-ac2

>o	Fix 8390 non modular not exporting syms		(Sang-yong Suh)
>	| different fix but Sang-yong found the bug

This breaks compilation with CONFIG_NE2K_PCI=y . I get

ld -m elf_i386 -T /home/src/linux-2.4/arch/i386/vmlinux.lds -e stext arch/i386/kernel/head.o arch/i386/kernel/init_task.o init/main.o init/version.o \
        --start-group \
        arch/i386/kernel/kernel.o arch/i386/mm/mm.o kernel/kernel.o mm/mm.o fs/fs.o ipc/ipc.o \
        drivers/block/block.o drivers/char/char.o drivers/misc/misc.o drivers/net/net.o drivers/parport/parport.a  drivers/ide/idedriver.o drivers/scsi/scsidrv.o drivers/cdrom/cdrom.a drivers/sound/sounddrivers.o drivers/pci/pci.a drivers/video/video.o \
        net/network.o \
        /home/src/linux-2.4/arch/i386/lib/lib.a /home/src/linux-2.4/lib/lib.a /home/src/linux-2.4/arch/i386/lib/lib.a \
        --end-group \
        -o vmlinux
net/network.o(.kstrtab+0x87b): multiple definition of `__kstrtab_NS8390_init'
drivers/net/net.o(.kstrtab+0x2a): first defined here
net/network.o(__ksymtab+0x480): multiple definition of `__ksymtab_ei_close'
drivers/net/net.o(__ksymtab+0x8): first defined here
net/network.o(.kstrtab+0x851): multiple definition of `__kstrtab_ei_open'
drivers/net/net.o(.kstrtab+0x0): first defined here
net/network.o(.kstrtab+0x862): multiple definition of `__kstrtab_ei_interrupt'
drivers/net/net.o(.kstrtab+0x11): first defined here
net/network.o(.kstrtab+0x86f): multiple definition of `__kstrtab_ethdev_init'
drivers/net/net.o(.kstrtab+0x1e): first defined here
net/network.o(__ksymtab+0x498): multiple definition of `__ksymtab_NS8390_init'
drivers/net/net.o(__ksymtab+0x20): first defined here
net/network.o(__ksymtab+0x488): multiple definition of `__ksymtab_ei_interrupt'
drivers/net/net.o(__ksymtab+0x10): first defined here
net/network.o(.kstrtab+0x859): multiple definition of `__kstrtab_ei_close'
drivers/net/net.o(.kstrtab+0x8): first defined here
net/network.o(__ksymtab+0x478): multiple definition of `__ksymtab_ei_open'
drivers/net/net.o(__ksymtab+0x0): first defined here
net/network.o(__ksymtab+0x490): multiple definition of `__ksymtab_ethdev_init'
drivers/net/net.o(__ksymtab+0x18): first defined here
make: *** [vmlinux] Error 1

Backing out the change to drivers/net/8390.c makes it compile.
-- 
Henrik Storner      | "Crackers thrive on code secrecy. Cockcroaches breed 
<[e-mail]> |  in the dark. It's time to let the sunlight in."
                    |  
                    |          Eric S. Raymond, re. the Frontpage backdoor