Re: [patch] Remove the "none" entries from /proc/mounts

[H. Peter Anvin]

Followup to:  <[e-mail]>
By author:    Erik Andersen <[e-mail]>
In newsgroup: linux.dev.kernel
> 
> --- linux/fs/super.c.virgin	Wed Jun 28 22:42:35 2000
> +++ linux/fs/super.c	Wed Jun 28 22:44:49 2000
> @@ -443,6 +443,9 @@
>  		path = d_path(tmp->mnt_root, tmp, buffer, PAGE_SIZE);
>  		if (!path)
>  			continue;
> +		/* Filter out virtual filesystems that are for internal use only */
> +		if (!strcmp("none", tmp->mnt_devname))
> +			continue;
>  		len += sprintf( buf + len, "%s %s %s %s",
>  			tmp->mnt_devname, path,
>  			tmp->mnt_sb->s_type->name,
> 
> 

Now, what if you do what *most* people do for proc, devpts, and shmfs (and is
the recommended option), and use "none" for the device there?

Lines like:

none /dev/pts devpts rw 0 0
none /proc proc rw 0 0

... are absolutely correct.

You have to filter out the "magicness" of these entries, not the
string "none".

<HARP>
We also need a standardized quoting system for these strings; or
alternately terminate them with \0.  Otherwise, this file can get
corrupted far too easily.
</HARP>

	-hpa
-- 
<[e-mail]> at work, <[e-mail]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt