Re: -Werror in test3-pre2

[H. Peter Anvin]

Followup to:  <8jhg4o$15i$[e-mail]>
By author:    [e-mail] (Linus Torvalds)
In newsgroup: linux.dev.kernel
>
> In article <[e-mail]>, Garst R. Reese <[e-mail]> wrote:
> >I'm just curious to know if any kernel has *ever* compiled with this
> >flag?
> >I don't recall seeing any without at least one "defined but not used".
> 
> My kernel certainly compiles.
> 
> I checked that every single filesystem can be compiled with the flag.
> 
> But yes, the fact that _I_ am anal about not having warnings does not
> mean that everybody else is. I added -Werror to see if people would fix
> some of the things it shows, and I've already gotten some patches. More
> are certainly needed.
> 
> I'll probably end up dropping -Werror at some point before the real
> 2.4.0, if for no other reason than the fact that there are lots of gcc
> versions out there that complain about bogus things (the signed/unsigned
> comparison warnings in some gcc versions are basically not possible to
> fix, which is why no "real" gcc version does this warning by default to
> my knowledge). 
> 
> And anybody who isn't interested in fixing them might as well remove the
> -Werror from their makefile too.
> 
> But maybe it will cause some cleanup.
> 

Oddly enough, when I tried it, fs/super.c had warnings, keeping
everything from compiling (without removing -Werror, of course.)

Also, *EVERY* module has "defined and not used" warnings, due to the
fact that gcc doesn't understand the init/exit methods on modules.

	-hpa
-- 
<[e-mail]> at work, <[e-mail]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt