Re: -Werror in test3-pre2

[Russell King]

Giacomo Catenazzi writes:
> Another usefull compiler flag to add is: '-Winline'
> It warns if a inline function cannot be inlined. With this option and with
> -Werror we can eliminate all 'static inline' and 'extern inline'. And
> developers are sure that inline are really inlined.

Ug, what?

If you don't specify "static inline" or "extern inline", then you have
the inline function placed out-of-line and globally visable in each
and every file.

Imagine what the linker does when it finds publically visable definitions
of add_wait_queue in each and every object file.  I think you may get
a few complaints, along with a certain lack of "vmlinux".

We want at least "static inline".
   _____
  |_____| ------------------------------------------------- ---+---+-
  |   |         Russell King        [e-mail]      --- ---
  | | | |   http://www.arm.linux.org.uk/~rmk/aboutme.html    /  /  |
  | +-+-+                                                     --- -+-
  /   |               THE developer of ARM Linux              |+| /|\
 /  | | |                                                     ---  |
    +-+-+ -------------------------------------------------  /\\\  |