Re: console_lock too early in printk???

[James Simmons]

> console_softint() calls change_console() calls kill_proc().
> 
> This means that we're delivering a signal from within a softirq.  Looks
> like it can call wake_up_process(), kmalloc(), etc, etc.  It also checks
> the permissions on *current!
> 
> Is all this activity legitimate from within a tasklet?

Yes it is legal. BTW kill_proc is only called when the virtual console is
in VT_PROCESS mode. This is used for manual VC switching when the vitrual
console is in RAW mode. Also kmalloc is not called. Note a new VC is not
allocated in the interrupt handler as stated in console_softint. 

> Secondly, this is all done with console_lock held, so if anyone does a
> printk() will it not deadlock?

No. The point of the lock is to insure that printk, vcsa, or softint are
not being used at the same time.   

Q: Why did they deprecate a.out support in linux?
A: Because a nasty coff is bad for your elf.

James Simmons  [[e-mail]]               ____/| 
fbdev/console/gfx developer                             \ o.O| 
http://www.linux-fbdev.org                               =(_)= 
http://linuxgfx.sourceforge.net                            U
http://linuxconsole.sourceforge.net