Re: [PATCH] Fix test-2.4.0-pre8 compilation (was Re: test-2.4.0-pre8)

[Jakub Jelinek]

On Tue, Aug 08, 2000 at 11:19:48PM +1200, Chris Wedgwood wrote:
>     3) don't use mem_map_*reserve wrappers in af_packet.c (alternatively
>     wrapper.h can be included)
> 
>     4) I haven't found get_mem_map definition but I think virt_to_page can be
>     used instead
> 
> test6-pre8 includes changes too get_mem_map and the mem_map_*reserve
> so I assume it's now the preferred API -- so all your patch does is
> effectively revert stuff.

get_mem_map appears in place where pre7 used to do:
	for (i = MAP_NR(table); i < MAP_NR(table_end); i++) {
and now
	for (page = virt_to_page(table); page < get_mem_map(table_end); page++)
so I wouldn't call it reverting stuff (unless Linus has some special intent
with get_mem_map like making it a const inline so that it is never evaluated
more than once).
On the other side, if mem_map_*reserve are the preferred API, it should be
IMHO moved out of wrapper.h because the name of the header suggest it is
something non-standard.

	Jakub