Re: [PATCH] aironet4500_cs.c kmalloc checking

[Bill Wendling]

Also sprach Arnaldo Carvalho de Melo:
} Hi,
} 
}      Please apply this patch.
} 
} - Arnaldo
} 
} --- linux-2.4.0-test6-pre8/drivers/net/pcmcia/aironet4500_cs.c	Fri Jul 28 06:34:44 2000
} +++ linux-2.4.0-test6-pre8.acme/drivers/net/pcmcia/aironet4500_cs.c	Tue Aug  8 11:28:40 2000

[snip]

} @@ -177,8 +180,17 @@
}  
}  	/* Create the PC card device object. */
}  	link = kmalloc(sizeof(struct dev_link_t), GFP_KERNEL);
} -	memset(link, 0, sizeof(struct dev_link_t));
} +	if (!link)
} +		return NULL;
} +
}  	link->dev = kmalloc(sizeof(struct dev_node_t), GFP_KERNEL);
} +
} +	if (!link->dev) {
} +		kfree(link);
} +		return NULL;
} +	}
} +	
} +	memset(link, 0, sizeof(struct dev_link_t));
}  	memset(link->dev, 0, sizeof(struct dev_node_t));
}  
Are you sure this is correct? You are zeroing out the link structure
(which includes the kmalloc'ed link->dev pointer) and then trying to zero
out the link->dev pointer. It's a memory leak and NULL pointer reference.
How about this instead:

	link = kmalloc(sizeof(struct dev_link_t), GFP_KERNEL);

	if (!link)
		return NULL;

	memset(link, 0, sizeof(struct dev_link_t));
	link->dev = kmalloc(sizeof(struct dev_node_t), GFP_KERNEL);

	if (!link->dev) {
		kfree(link);
		return NULL;
	}

	memset(link->dev, 0, sizeof(struct dev_node_t));

}  //	dev =  init_etherdev(0, sizeof(struct awc_private) );
   ^^ C++ style comments...blech! :)

-- 
|| Bill Wendling			[e-mail]