Re: sys_setuid bug found (the Debian man man setuid problem)

[Linus Torvalds]

On Wed, 9 Aug 2000, Cesar Eduardo Barros wrote:
> 
> I found the cause for the Debian man man bug (in which you can't run man as
> non-root user since 2.4.0-test6-pre1).

Good catch.

The set_user() for that particular case should just be dropped in fact,
turning that case into an empty case too. I mis-read the original setuid()
code.

>         }  else if (uid == current->suid) {
>                 if (set_user(uid) < 0)
>                         return -EAGAIN;
>         } else

So just turn the above if() into an empty statement (and obviously it can
then be trivially cleaned up ;)

		Linus