Linux-kernel mailing list archive 2000-32,: Re: [CHECKER]: malloc/free errors part III

# Re: [CHECKER]: malloc/free errors part III

Johannes Erdfelt (johannes@erdfelt.com)
Fri, 11 Aug 2000 21:20:41 -0400

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Johannes Erdfelt: "Re: Via Apollo Pro 133A"
- Previous message: Alexander V. Valys: "Via Apollo Pro 133A"
- In reply to: Dawson Engler: "[CHECKER]: malloc/free errors part III"

On Fri, Aug 11, 2000, Dawson Engler <engler@csl.Stanford.EDU> wrote:
> ------------------------------------------------------------------------
> /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:1115:usb_parse_configuration: ERROR: did not free config on error path
>
> Not sure: looks like you'll just overwrite it on the second pass:
>
> config->interface = (struct usb_interface *)
> kmalloc(config->bNumInterfaces *
> sizeof(struct usb_interface), GFP_KERNEL);

Second pass?

FWIW, usb_destroy_configuration does free this.

This is assuming that whoever calls usb_get_configuration (which
eventually ends up calling usb_parse_configuration) handles the error
code correctly and calls usb_destroy_configuration, which it doesn't.

> UNSURE, but it looks like all these interface allocations will be lost.
> If it fails, they just get overwritten.

I don't understand what you mean by "overwritten"?

> /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:1038:usb_parse_interface: ERROR: did not free interface on error path
> /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:1023:usb_parse_interface: ERROR: did not free interface on error path
> /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:990:usb_parse_interface: ERROR: did not free interface on error path
> /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:956:usb_parse_interface: ERROR: did not free interface on error path
> /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:1057:usb_parse_interface: ERROR: did not free interface on error path
> /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:1046:usb_parse_interface: ERROR: did not free interface on error path

Why did it show many of those multiple times?

These fall under the same category as the first.

Randy, I'll submit a patch for these.

Dawson, thanks for hacking this test up!

JE

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

- Next message: Johannes Erdfelt: "Re: Via Apollo Pro 133A"
- Previous message: Alexander V. Valys: "Via Apollo Pro 133A"
- In reply to: Dawson Engler: "[CHECKER]: malloc/free errors part III"