Linux-kernel mailing list archive 2000-40,: Re: [PATCH] fix for VM test9-pre7

# Re: [PATCH] fix for VM test9-pre7

ehrhardt@mathematik.uni-ulm.de
Mon, 2 Oct 2000 14:05:59 +0200

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Marc Lehmann: "Re: What is up with Redhat 7.0?"
- Previous message: Manfred: "Re: set_current_state() vs current->state"

Hi,

On Mon, Oct 02, 2000 at 12:42:47AM -0300, Rik van Riel wrote:
> --- linux-2.4.0-test9-pre7/fs/buffer.c.orig Sat Sep 30 18:09:18 2000
> +++ linux-2.4.0-test9-pre7/fs/buffer.c Mon Oct 2 00:19:41 2000
> @@ -706,7 +706,9 @@
> static void refill_freelist(int size)
> {
> if (!grow_buffers(size)) {
> - try_to_free_pages(GFP_BUFFER);
> + wakeup_bdflush(1);
> + current->policy |= SCHED_YIELD;
> + schedule();
> }
> }

This part looks strange! wakeup_bdflush will sleep if the parameter
is not zero, i.e. we'll schedule twice. I doubt that this the intended
behaviour?

regards Christian

    --
    THAT'S ALL FOLKS!
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

- Next message: Marc Lehmann: "Re: What is up with Redhat 7.0?"
- Previous message: Manfred: "Re: set_current_state() vs current->state"