Linux-kernel mailing list archive 2000-40,: Re: hdparm -d 1 fail test9-pre8

# Re: hdparm -d 1 fail test9-pre8

Andre Hedrick (andre@linux-ide.org)
Mon, 2 Oct 2000 14:32:04 -0700 (PDT)

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Chip Salzenberg: "Re: [PATCH] 2.2.18pre13: eepro100 debug tweaks"
- Previous message: Roman Zippel: "Re: SA_INTERRUPT"

On Mon, 2 Oct 2000, Mike Galbraith wrote:

> Greetings,
>
> In order for hdparm -d 1 to work in test9-pre8, I had to reverse
> this change. (Without being able to enable dma, performance here
> is muy el-stinko;-) Is enabling dma manually now forbidden? (or
> am I maybe missing something else?)
>
> diff -urN linux-2.4.0-test9-pre7/drivers/ide/ide-pci.c linux-2.4.0-test9-pre8/drivers/ide/ide-pci.c
> --- linux-2.4.0-test9-pre7/drivers/ide/ide-pci.c Sun Jul 30 06:30:13 2000
> +++ linux-2.4.0-test9-pre8/drivers/ide/ide-pci.c Mon Oct 2 10:11:36 2000
> @@ -538,7 +538,7 @@
> * Can we trust the reported IRQ?
> */
> pciirq = dev->irq;
> - if ((dev->class & ~(0xfa)) != ((PCI_CLASS_STORAGE_IDE << 8) | 5)) {
> + if ((dev->class & ~(0xff)) != (PCI_CLASS_STORAGE_IDE << 8)) {

Why are we changing the enable code?
If you are not a registered device in the list and you do not report with
a storage class of 0x0101, then you do not get enabled, period.

This is going to break a whole bunch of cards and systems.
So undo this nonsense and stop dorking up the cards.

Sheesh the chipset folks are making ATA hosts that report as
SCSI 0x0100
EIDE 0x0101

RAID 0x0104
MASS 0x0180

Do not mess with ID clas signatures! Please!

> printk("%s: not 100%% native mode: will probe irqs later\n", d->name);
> /*
> * This allows offboard ide-pci cards the enable a BIOS,
>
> >From dmesg:
> Uniform Multi-Platform E-IDE driver Revision: 6.31
> ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
> VP_IDE: IDE controller on PCI bus 00 dev 39
> VP_IDE: chipset revision 6
> VP_IDE: not 100% native mode: will probe irqs later
> VP_IDE: VIA vt82c596b IDE UDMA66 controller on pci0:7.1
> ide0: BM-DMA at 0xe000-0xe007, BIOS settings: hda:DMA, hdb:pio
> ide1: BM-DMA at 0xe008-0xe00f, BIOS settings: hdc:DMA, hdd:pio
> hda: IBM-DJNA-352030, ATA DISK drive
> ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
> hdc: MATSHITADVD-ROM SR-8583A, ATAPI CDROM drive
> ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
> ide1 at 0x170-0x177,0x376 on irq 15
> hda: 39876480 sectors (20417 MB) w/1966KiB Cache, CHS=2482/255/63, UDMA(33)
> hdc: ATAPI 32X DVD-ROM drive, 512kB Cache, DMA
>
> please cc mikeg@weiden.de, as mikeg@wen-online.de is nothing but a
> mail black-hole. (provider must be trying to trim his customer base:)
>
> -Mike
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> Please read the FAQ at http://www.tux.org/lkml/
>

Andre Hedrick
The Linux ATA/IDE guy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

- Next message: Chip Salzenberg: "Re: [PATCH] 2.2.18pre13: eepro100 debug tweaks"
- Previous message: Roman Zippel: "Re: SA_INTERRUPT"