Re: [PATCH] 2.2.18pre13: eepro100 debug tweaks

Chip Salzenberg (chip@valinux.com)
Mon, 2 Oct 2000 14:33:40 -0700

According to Alan Cox:
> > + case SIOCDEVPRIVATE+5:
> > + speedo_debug = *(int *)rq->ifr_data;
> > + printk(KERN_DEBUG "%s: set debug level to [%d].\n",
> > + dev->name, speedo_debug);
> > + return 0;
>
> Surely that should check for root ?

Now see, this is why peer review is a Good Thing. :-/

Yes, of course it should check for root.
(I'm dunce-for-a-day for not seeing that immediately.)

-- 
Chip Salzenberg              - a.k.a. -              <chip@valinux.com>
"I wanted to play hopscotch with the impenetrable mystery of existence,
    but he stepped in a wormhole and had to go in early."  // MST3K
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/