Re: [PATCH-2.2] Bonding Driver Enhancements + Security fix

=?iso-8859-1?q?willy=20tarreau?= (wtarreau@yahoo.fr)
Wed, 4 Oct 2000 03:15:01 +0200 (CEST)


--0-278722862-970622101=:23487
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Content-Disposition: inline

Hello Thomas,

I've modified the slaves lists as you suggested to me.
The more I
tried to optimize the code, the more it looked like
2.4's, so it
seems the last one is already optimal. There's no
slave_queue
anymore, and the transmit path in bond_xmit_roundrobin
is far
faster.

I have also implemented a second xmit method :
active-backup :
instead of alternating on the slaves, it always emits
on the
same until its link fails, then it chooses the next
good one.
This way, there's only one active device at a time,
and backup
links are still monitored. This is very useful for
high availability
with 2 switches (one link to each one). Of course, I
tried to make
all the backup slaves deaf and for that I set their
NO_ARP flag, to
prevent the switches from seeing the interface at two
different
places. This may not be enough, but I'll try this
tomorrow on my 2
alteon. So for now, there are two xmit methods :
- round robin (default, or mode=0)
- active-backup (mode=1)

the mode argument should be given to modprobe when
loading the driver
as a module.

For the MII link monitoring, I've set the default to
disable checking,
to avoid any potential breaking of existing
installations. To activate
it, simply pass "miimon=XXX" where XXX is the check
interval in
milliseconds. At 10ms (one check at each jiffy), my
mouse becomes a
bit "jumpy", but 100ms is quite good.

I wanted to write some doc, but I will do tomorrow if
I can find some
spare time. It's too late for me to write something
correct and I must
get up in 3 hours. But I've included your
Configure.help patch.

So for this night, here's my patch against 2.2.17
(should be OK for
2.2.18pre15). I'd like several people to stress-test
it.

> See this:
http://docs.sun.com:80/ab2/coll.539.1/UGTRUNKING/@Ab2PageView/1311?Ab2Lang=C&Ab2Enc=iso-8859-1
>
> for information on the 4 possible trunking
> transmittors.

Thanks a lot, I will take a look.

Willy

___________________________________________________________
Do You Yahoo!? -- Pour dialoguer en direct avec vos amis,
Yahoo! Messenger : http://fr.messenger.yahoo.com
--0-278722862-970622101=:23487
Content-Type: application/x-unknown; name="patch-bonding-20001004-2.2.17.gz"
Content-Transfer-Encoding: base64
Content-Description: patch-bonding-20001004-2.2.17.gz
Content-Disposition: attachment; filename="patch-bonding-20001004-2.2.17.gz"

H4sIAFSf2jkCA8Q8a1cbx5Kfxa8ocw9Gsh4IDH6A4QZjnHBiBGuwfbK7ObqN
1EJzGc0o87BMYu9v33p0z/SMRiCcZDcnBmmmu7q63lVdzdAbjaCdRj3wvSD9
0t7qbHU2n2+8CQfpRAeJSrww2DgKg5F3nUa6M9b+tDCyfRUGwzuHr7Tb7eWB
195GHlzoKcAL2Nrc3dre3dmBrW63u9JsNh+4cu2THsLZIAHYhu7T3e6L3c2n
AuuHH6C9/eL5y9YzaPLvrRfwww8rAJB4E92C2zCFQOPsJIRBOJl6voZk7MUw
jLzPOgIVg4JJOEx93YGTIE60GkI4IgDrw3QyuV1v4XgNQ/3ZG+gYZp7v04MA
rjQMlO8jaBnYxZHyaXMddDLorMBK8zXuzAuu7WpxOp2GUbLSPDrrvT35sf/6
rPfmpPfjShPgQt3C+i/rEEawfroO3ohRn3nxmFDHxdQVoR7COlFrHSapn3hT
fHSM2ESBTgjI0VgFgfZjHHet6XkHLmmz+L/FlYcPZNw6XN3CkRcPwhbNXr+M
0uAG0eXnF2nQAhXgFLMJRCqAd8S3zkqTxp8IjmP1GRGbhaANJkhohD4gPhIm
EIcTDSG9ZBakiY6EMQMVEJyJuiGm6Aluk4H5Hj4IA6R6mNKu4ylxMIcKaUxE
dfjYITg9laQRbvO2Ja/GKja0M3RHICphdgo2GneHY2ba91ugPXpGcGb4CaUi
9iaeryKwPOStm/WQMkI42NnpdiHGKYMx8U4xL9PAkpI+X4SjJMeTBlim2CUQ
S8Lq+D/eZfCv0gS8BCY6ukaxs0yGWF+TksQExcvEFR9HnvJJq3Rs1niL2EzC
SOOwURhNWK1agBKjYiSI1lBUOAQ+CyNCeeNKNtxJviRFTs9UkMwpkqNBUId9
fDnUMBt7SA/kL1LfoKqZ/ihCJFORnoSf8esoCie8dSRXQOS6oW36OF8HmjTG
LttgCY1RSU4BSaENFNx9cRuCSMy4I5m1xYz1VnAxmmB3GdIe4eLdyTnUHTI2
MmUFo6w0hOwCaeovVkG9ICEpQqKkSFaGgnQ/EnBEp0jHMa5GDxo4bGVYbaaF
7TGxIaP/oMJKVo6bN8yVw2oXKP1kkZ92YXNrdye3otUWuRpIyRQ/293q5qZ4
a7O12YWm/GI7/ATsf8yCSIsAIg8g9lHZ4xbqP8udmAAUp2E4Czo01U73Rjrg
wcy0Lhma7kobntQYpEoSNUBO01PWdx7DYsmTOiCvxjNcaQBqOCSeCDqZ0hdg
/RlQiHJN7ZLRSYnvONcLvISkypnBo652SYhUGZjySaxvyTwQQPRhtOR6XB7H
BLBkZY/Elg5tBCsVo97hnRUGVYyxlP7c7WxCG0ZeFCdgjAGQBKBideyILRxB
7uMaNxej0lkTi1o1SH1FOo7OI0Y/SLOFxTKwwxLydKv1HJr4c+u5FZAjBhfv
8pfDKFD+MIQjFX1W/jhEzwun2g/hlRpM9A/oBMgHfFYdVK7OVXTAkwjpL4CS
dROj34CR8vyUbETCW+wTB4hcQOSgfyywG92XG6gJbfiExLmFSxUh4VN4NeOv
imxvotpfOmF0fcCT6L820Z/CCdQNYipbO6RAJteyZRMvdJx5iCGRTA/SyEtu
0b5fQ/3o8LzfO77sH745PelBEKLrHOvBjR42nIneBI02WTicfnpyQop6g2YN
9xRGrDZIIy/m8GBIBpHex7CbQQA4RObTzIGa8jDDFYUkMusBGdtbeDXxPIR8
AOiWfA9xRerFDqD6Jjq7SUzuA39eh+GwYSIM5FWqjcHP5AMFYapi9tUeOQ4H
EjoEtMwdODQz0Yf9rqNsJyz77ibrQz1SGPI05kmKa6KLIx5j5BCGU/IxzPYv
Ey/pR2EaDKPwygvqDXYrolWoT4GLD+3F6LizwEQNOTIRNo/DqR6lJBwXp+fo
i0a6KE+bKFJPHyxP4RQjVe93bZZH9sWoVFeKrAfKMgnWZ/K7cXqNSiJBFWvv
5TicoHl5oz578QJxUaQqun2lBjfplNYfh+yrwqtEIZV+OpRYh4I3CWFIC3Oi
oNrekgXzQ+QA/p6GyEwSoJCpiCTAwE7WYEcYjdQA7RU6f/K42oGk/Di07OSp
BiUK8uqZUJOZSOMGitBAkTud6SzkuAnCmSs+I3pJAmzDYhOCIZlVcMvBfwfD
ERI/WEVJ0/ubqzRM5A5c/fJDpDfFUAnb1YSIHFzHLhacQbAIk3hzVIUilcYU
TCqmhYPbzEM48Ah228xmMlAbmAvAP7xg4KcoR6/Y1W4MOMXpjA9MEkMpzLMX
LTGL5cETdJjhgAbPvUK8yTNXvSKloBfN8guiT1SaouLJRnyLIeWk4sUVcm4a
V7zwQruDZ93WNvr+F5utZ88q9xDfXKWjEcOoQHXUtzFGFcLxZCoT2yQk3oDk
LdfyOtIgxZgkvunTEvAEl2qBeSimGJ7g78beSnPjSSaIFISItUQ2JigDGMtB
HRXDNX9o4V7td3PD5Bgl5CsiOgrQNgGlcv13J72f+6dnvf5J7/L4/Ud8i68w
mKx8W8O46x8YPHqjlaazKTHBGEhXzdkrDiWrBHbo6dmb4/77sw+9N+/PXp/0
9ih0x2cf3h33zw/fn9YFcAtWvVWiQ+EVAspeFJaoNKQPoHYlKDEZYgIeAAwM
MPMSw9K+DOhLIPKEV8DEV77X78Toc+hJDtA3DF0wnGS1vAn0A0HV8BX4Y6VZ
My9YxfpkzeEJf0Y+Pa7baUbW4UkDPdvn9sEU44lGo33AI3GrNWQP8vyo/+Hi
uH+ETL1kztTQ8BlGwgF0G/AHAAo0W0925WKH0ae2oCTHHRbXWo1sQp+XqfNP
2mStxh/bB/rLlK0X4vpvTFQ8/NjMFnwCP/0nbADGAN3CpKFKFFu+fainQexd
B2gtyWc0cGvuwFEaSP6OA5n+TxqPXRbwWIyv5tD7RnyoRRrz+wC6SJ5vVWwZ
+GGsy3xBF4kEYda0a4bqfWQJERyjVUJljiUgk4QreziPPXP/t1SnmubyB2em
85pmG9DtA36Sz8eZ/KEFTwL9JaGNOQjRx2WwaZagkbAUqA4jX13He2QrazGN
5O91/tkgbAa+V2eyzjAS1X30Kzd9L/qNxtaZH+0DetYCO+WvETxkV5T0r8Z9
lYQTbyAo1IbaN+w2SztCicaxPP4bb2uE6ipU32catw/GGPnumQjq0T70Prx7
twcN1kccDHa0LMHUzwfXM4I26L3MQwc1snb9pPdj/83x6w8/IqlryIUguamv
jiKtiUH7sBb/d7DaEnioDaTOAUZGZLGMfcdp7lumKzzeh/85efu2f/Hu8OPx
XnmMYGd2gluuEdL43YwRAcLHN4SH7ICZK0D2s/eGPkE66UvY324zbS38Arxm
AR5JnBheJHu75lA6w0skWKbjQ/lCs7IvmO5EGIz27XplYiNwhI02B/W/LKpW
QtPAyqgZVy2mYMzmm+OC2XQNB8Upm91nrac70Nzcedp6+pIjlXlbYgoO1dZk
zj8J+f8/bcycKaF9Z6QO9Kx/j7Go4f+s44wW7AuH4etXoyfmQYOIbAnaPu5h
zPGRKC/rL2W/FqqWaBbUfz5+3+t/Onzfw5ewuhbvgnCDwK2vxeusbRYoaVqm
e2W1u88CGrtm9S7se+Eg8bO9kj4YdWecGFFY/aQirlXuYgo5l42bqiGQ1Ska
BoNc8wGGl4iNVpYKA6ZAysa0zVhbtI01gToZkw/nX+nX+w89ol6jwfat8gXJ
6kK9q4IvUBii/Ujm9YE66gjPSe/j4TuxLmajtvZltG/ImZMjlkVk2HBmElrx
7p5Nfj/mrz9c/GIQr1F5zSBZz/QMFeFGUrZ6jLl9OLJmr9GCH9+e90mcjt8h
FzK1+psw7Z2dHp9aVCd6Euskx7IFXZTOIn4NYyS3t1tbmJBuvtxpbT23VrKW
TWUvZd2HxBpEgYKPKGyt6D0cg5S/K7sK17XjsG+gfUzHXWiJ8vzM+TgwmyRM
YivN0QoV6THH56qFVL8kMqfIxNlUwXXRl73ie7OUpZb1YXMwqpEqAcqWcwcJ
7lzfWOfDm3IRh1M1W5Og+gmdhISBfytfeDACyQsycg5ipmdPTdVaDu/G2oug
d3b4/pyFiCrEBKJcAeECvSn3hlRmSjQuO9RqxEiQmeJSaDwN+UyEYFA1huBG
GvmBFDelI3PcROMVpwKjMPTJfipTySGs07hFIGIvGDAS16mKFG5AS75elBfl
z9Qt1ag8qRjRKj5aDYKQSnnUrVFp+DfVb2T/IZW5vdGtnGhlw9ZjJkcHQbCg
sCGinHvfTbkPjy5PPh6/Pjz6OTOJbAwq45+5AIidDCVPaMeqphRDRrZtzKiG
WapWHWYV5K5W0ttyBMoA9yieLxfzTOhedM0nvbdn4pcnis8I1qRcW57cIe/H
02t3eWsc8I2jfdHuxeh+3YcitmWZvgfbPIpYM8eWZQAPwRhMLuKYorJhm4u9
m018/FeGu6WUmIpbCyzGYBxidhwb5ZvNczo7ijXTpqiQfOjKuo0WIZ+bTyIq
MiAxMohv6id0dKVEEXV2to3rx5qP+8H4njCyR2xk7gKyXiOqMUGdjQhvjFoH
UCfpHEr5Hh9T4PZGBNecuPCBAICJyVAkSaunaQJELDrjYJCMAZX7GBvELytF
0NJo2/QQ4ZD4ZNophximVtXPtlwvxdmihm6knWU61ZpZqePkDkxsOAxzG5JD
q7YbNUywEy+QBCALQarshokB4SsUo8D9/YWvMlVcxnBwD4eXuHaAGGoU0nCz
vtBW2fzV2IJv5gyh7lAAckyYWhSHVsBrGO8fhNbqG3lm2WoBOi006wahVwTg
QLC8G8cy9XEVKko15zNHI5cPzhwrMjhHrsI0yu15ZQbXrFkPdW8G15zP4Jpc
yb43KzMZEFlT2Sep5r/W4n/dm5Nlpe4HpYoPq1GxHPLmy4kEWxshA0Up2WMK
DoDeobjI6xEfUKGFMJAyx784BWkQjR/VF2YhRpUWEXKgAk7wzAmySRrv8T8P
8hTNudSlKS6XUpdmLZOtqvIM88Aoozsw++yoY1lJckPmjOa8wSQO1siUgGWB
sfPcBuOFwYVQuwREUK+RUAzDYJ0z8mvNoWE6HVJZpqjjiCa7LHOkzjIgb4wR
K+yDtlBlfWhDEkDcG8WzXzVxqExBdtjGqKp4iqPWFDcRJP5tNsN2N6L4oC4p
dtBoejsywOC+bOgqg3n0Xf6vUeWQ4A9gu5v5cbv2woAsNyFz0QhGaKt2dm1V
sosqg+5EbPcHbTUTadYKweZ34tdyEZScxYiOwW8tXhK5FiyO+8vIyyezC94E
0ly6GYm9MexSU+EU0zKyCCpK8rhO+noKIr0oe5hXJWd1qRBnQxqOok11NFZT
6qiEeBym/pAsLXXicL5GSDihI+drPJP7L7Q0fkmPxlBTH5ZpHJH8jz4kkrLG
cuIuM7kJ4eScten08Mj2R2kO8TmeJW8j/rYljYl26kTdSubsU1UCOTeLyKFy
F6qHG4w7cHZ59lMrFwQ7k9smPAyJDeXE1NKBcjiTVTFv5vjWm0z00FOUKdvJ
eR6Ce1LXygtEWYkp/KHoSYrHBBmtGXFj9hkVE7lJBo8a7BYlNTeTMn0da1Zd
4BPJKLwzmZdZwSLxUB+UZyt8djREonIIfvazQeqbOerLSyBAFlu64DyK22xF
Im/JhpmK2ac7NueBaVR7riRZHQs1F7rwtbgQViwfDM35Zd4+7r6UpGT925G+
Tn0VIeuTvKFGU88ir7Aec0FajtyWP+s2h6RVUeiSR5J3nHk7x3pVp5dOOIs2
Aw1W6A+ZNy1yZVlwWx3zMgXVcPn4cGZagZPoVmpVSnyt039EdUKmKP5GI5C1
qaKBkXCRtElKZo5SiNqp6TQKkSis7x3uwc6ZQzJiIMghARGTmp9kXXbvMw5V
MAdUwa0kvnEo1lOxSWnHUzSeAgWXuo7UBAZsad3uKt4N2gTtjwoJrjUxi6O9
LNarOB+8I8ZzkqA6qi6dojTKQpblPh46kN/oOw4XyzDfS5GvbHsICpPxJz9M
N5/hcOo/oN4D+tJ4jO86+K9Pj3kQ/SN7g9//q/srqDQJJ+raI426Ra8o3eC3
4p74/EesEY/f/BUhb3KKy21q4YD7zGETRYdYGNO1gBu4EMmxFpzzhbm6HcVY
jx+L7WM2W5axXXYqs7I+N1zWzYkUMDR7QtWwZ9wZQBkmjOai6mBAzWyEswON
RxFiLSAyteDi5OwI87/z9ycfDy+POazrZqk/R3OzlhDu6a90AYPaBmO+UQDq
KqQqi6M3u9bBtbMpj6H7pbsNE60CsUwYe1eP2uqaUaZST1xqB/o6HHhM8aKH
rCawrV0QdbomHi0GHV68Qf7C3jZwo+N6EWdDixwIY0+xB/ogutDiOlNqY5gr
juTesvaACFxiRbZU69QNGsaJdLhm1fxPWopc1KhI2p2YyyTF0gtpl4UGdOlB
6vg8U1IFDtQrin4duu6B0QIRioMMWyd1wDk5CZfRKYVNKUojWNxLS9Wajp2R
ZwJZ2LE4geI6tMcen3EolZQeOXlFbWF12K1Jmb1lwvN3ZDgLcwhXQVhkqMBw
d7pzZ8IDjwpJRTmtmE8a8pynnPX8aZxbRaSXSYIW4rt0EuTsJ/tQ2teCbc0d
F6zFol8UPXPYVET1Xsp+WyKpXIq2REo01ftr3a0vLg6mo3ghyYzJKme332y+
luE0bwlRs8gF3WsJt4wl5A8LjWE6xWgN87nsXHBYaRqr84jvtY3XYdE0MoM7
cG6SUE4Y+LKfPRwVdaJ7ng6B2XySeWxl9tGkS+Zko9qILXm6JySbR8VoU7Up
K5XXXVvmzMtmVufwzunfkqrOJiYqabg54svJ8Z06sqSOVuBTobb/14pqMPn7
1LSQ+bJEmtty5sIsC89ctmEaGuQIrXCQJwlCQmduWTojgrHLblVuQ9K+6Apa
QgWQWCICUwyN4cN5nvHY5iN7EG4TM4q6bbqGnwsVcgxNy3HQ35F5uJ1Kf9mJ
1wJrRbqGGePNXpFl5qROJiGiliIGYPHcYL+Q1RbnlqLYP7JQd0nbOC/ITu2L
vJ1HdYpZZvTDoMqrO8pVKdhL+enc+XwXap25EkqpUcA5578D6JhrQ9l+i+f8
8+C/5QWFpataorKRbqtIImmpe7CafE9T/b099YK1M3SZrvr5pvrqFnr0fOMZ
VVAfdnzJHWPPn8kfYei2pF3sD+pArRguySzd06hjDto+oFzdVpLBqNMjc1Wx
eEOy0SgcZZ0fvz+9v5+0viq475P1luboJY7YbAsp7+wF3cpqbr/cMZezapxN
sTJeHF/+9OnwzZv3u07bXYmUGe3sJmvmMuMutbLl+zk7751dXnw4Py+e2DmP
ueeEGMd3rbvb9Ncumjubm62tHUFsvglYGitP5A6y93uhdCrcoT+yIV2lrMRj
FQ370qtPl3VMxwJ/3luuB0ra+u8GVbgDRHCtUt87Mb+HJLvLrs9U9FwW6pbF
1ss907PpTLddv1X9k3n3ZDah0D1ZXMlpQrDHc16RA9GMDElWzzbFbTr5ICcs
1Shb5dN0GBGDWb/RMfcJ7zhGz3CUdiOxXLajvJpITn95mVBtJ+A1QAqtnXIg
lF9j2pNW1iIF23SHAH+aXTjQKujoItP4a24ZGHq1D+Su2CIy6MBcH/NiNIxx
tcwUAOWkgAWkkIfOju/o0RXN3n7R2ibN3tlqvdwWzWaYVNWbJv0RGpSpSsZW
L0qP3Qb4ZmV0S8cIHhkllE06ylotR82l2z5OI/xq5R30WA7W14Ywicmy8tSG
q9d2OhUNKyCYm4fZML5FtBbzoSZ7a/rwz9XCKfrq7qqReZk91w735+6K/nX3
IOViSJUvnD8QaeFvNnwq2csdaKbby+l8rerSiNV/RxBZt3F3XLHbJ7q1a6zu
9UdzvYsSZS48hrmnIusUUyVGM9VTYIvfZxXpI/3q+K+gHt29rNPSJAiCrMDL
Ljzl7eLzgSkrYcV55x33ImqIRqnF/UEnTVkOY1hZbajmG/4W1xGk6iF/1IId
SBgmLT4eXXC277QGLpMnfV2UJX2typHK5DF0BvsK5TDkP3NBhyf8mLgsl5tE
CZnNRGkje5v87ZtlVTUz2QE8Kjifey4PVACQhZzLBEvdP2jeXWixlwq5QExY
ut1kWh5R6J13RD4kyShqQ6lFclG+bGUvP/ykJrfUS8q98KOIWijoADumVgbG
sEopH5oa5TibXsk72pNnmv/Egxx1VtGZeoqlw186gen0nEscpv4x/t9erqWl
YSAIn+uvWC9iWR9NHwQNCB4qVcRDRfAWigj2YCy1hUrpf3dnMrPZZ2K0eGo7
2Wy2m93Z+Yb5Pizodgv9uah3byz0A2lQvNt55f07T9mJvCdz6k1U+3Oqb+gV
HMbSm1Vu1avFNxxFLG+Q6Xa215ARpyFb7x73KPn/zRAlr/9By6CGbmrHAmFi
aYClHhsLh8z6FjRApIJfwkR2a+U3dm2E1Ea/wqsWwfiEMIQ7HA9GuI/r4pGD
fPBm8njZwnKqtQGQBWzajKjl7qyGr6etic8ePCEQr3zy/JuRgbHqtBXWMFJ/
8cLp1XKTL5TnBFaIVHd71ozEvnqoapP2KHOiN+CvNg+vCsZJg9EFJGbSBJ5C
3a8Lxja5mmw18uMj2L5UtA9hZBiOmdby1VRW7uCMMJ2IqfiRaM25L2kTkNeL
N/b1/OJtUdTvbl2I/hBF/dLL0bBO1K+mJ0/ZT2FQreyXpCeDgZDqgxRWWdoG
JGqenvPbG1YzzSchfR+tOCQdxaHFHFcBywKZgjnjh5Lii7UrTqmK03Q6vh9f
PwabCikSt7lO2wWb97uwRq0bHHEd1O7xrptZsE4CiHT1tXiF1KSJx0JgkKJn
qxmJhLhWLoQP9rAjyLfCpR56OqHBralKwgxbbQAym2VwYEuJGitsmPn/qEx6
5gS/Xt5mS2RkqR87YZ1IkKJy54kDqG3k+OIRvM8LYwRomW38MUWOncwmbpV1
ztqg5zkyB8qHYQ4vX9EfE4EqSKp6pAkoL3wUzScivkp9pmbgejmpAwEX7Tlc
eROIUb4BpgPSxf1ZAAA=

--0-278722862-970622101=:23487--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/