Re: [PATCH] tlan timer fix on tytso's list.

Torben Mathiasen (torben@kernel.dk)
Thu, 5 Oct 2000 19:35:52 +0200

On Thu, Oct 05 2000, Jeff Garzik wrote:
> * return value from pci_module_init and TLan_EisaProbe is never checked.
> If you don't care about the return value, just remove 'rc' var.
>

I was going to have some code here, but haven't had the time. I'll
remove it.

> * does TLan_EisaProbe work? It looks like request_region may be called
> twice for the same I/O region, once in TLan_EisaProbe, and once in
> TLan_Init (via TLan_probe1).

Yes it works. Check the code again: if (!priv->is_eisa)....

Jeff I'll make the other changes you suggested.

-- 
Torben Mathiasen <tmm@kernel.dk>
Linux ThunderLAN maintainer 
http://tlan.kernel.dk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/