Re: Bug in "ide-pci.c"

David Woodhouse (dwmw2@infradead.org)
Sat, 7 Oct 2000 20:18:17 +0100 (BST)


On Fri, 6 Oct 2000, Andre Hedrick wrote:

> void go_take_a_dump (float load)
> {
> if (pull_down_pants() && purge_bowles() && wipe_anus() && pull_up_pants())
> flush(load);
> else
> wear(load);
> }

But here you make another classic mistake. Consider the case where
purge_bowels() fails (-EWOULDBLOCK?).

In that case, you don't actually execute the subsequent two procedure
calls, which I'm sure we all agree is a suboptimal state of affairs.

-- 
dwmw2

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/