Re: [PATCH] 2.5.42: build nfsd as module broken

[Neil Brown]

On Saturday October 12, [e-mail] wrote:
> 
> 
> On Sat, 12 Oct 2002, Olaf Dietsche wrote:
> 
> > +EXPORT_SYMBOL(cache_fresh);
> > +EXPORT_SYMBOL(cache_flush);
> > +EXPORT_SYMBOL(cache_unregister);
> > +EXPORT_SYMBOL(cache_check);
> > +EXPORT_SYMBOL(cache_clean);
> > +EXPORT_SYMBOL(cache_register);
> > +EXPORT_SYMBOL(cache_init);
> > +EXPORT_SYMBOL(add_word);
> > +EXPORT_SYMBOL(add_hex);
> > +EXPORT_SYMBOL(get_word);
> 
> Ahem.  Non-static objects called add_word and get_word?  Even the cache_...()
> stuff is a namespace pollution (which kind of cache?), but that...

Fair comment.

The words are actually 'quoted words', so maybe:

 qword_add
 qword_addhex
 qword_parse  (or qword_get) 

 would be better.

The caches are for caching user-space-sourced information (IP ->
hostname, export options, uid->username etc) so maybe

  ucache_*
though that is a bit bland....

  uss_cache_*

(for the trekkies)???

NeilBrown