Re: [PATCH] ipv4: make arp seq_file show method only produce one record per call

Arnaldo Carvalho de Melo (acme@conectiva.com.br)
Wed, 16 Oct 2002 22:35:22 -0300


Em Wed, Oct 16, 2002 at 06:15:50PM -0700, David S. Miller escreveu:
> From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
> Date: Wed, 16 Oct 2002 22:11:08 -0300
>
> That would be nice, yes, bastardizing pos for this is, humm, ugly, and
> it isn't accessible at show time (pun intended 8) ).
>
> Can you remind me what the original objection was to
> just using seq->private? Is it used, or planned to
> be used, by something else?

lemme get my logs... here it is:

Quoting Al:

"You're free to use, but keep in mind that it's assumed to be constant over
->start/->stop/->next/->show more accurately, there's no sane way to use it as
part of iterator state it's for "which of iterators with similar code it is?"
e.g. /proc/<pid>/mounts uses the same iterator over different namespaces -
depending on pid. take a look at the way /proc/ksyms is done"

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/