Re: [PATCH][ATM] assorted he driver cleanup

David S. Miller (davem@redhat.com)
Sun, 01 Jun 2003 18:32:35 -0700 (PDT)


From: chas williams <chas@cmf.nrl.navy.mil>
Date: Sun, 01 Jun 2003 14:57:02 -0400

but on a single processor machine (i.e. #undef CONFIG_SMP) there is
no chance that there will be reads/writes from other processors so
i dont need any locking OR protection from interrupts.

Either you need to pretect a code sequence from an IRQ context
execution while holding the lock or you don't. :-)

Really, all your macros just make the driver that much less
portable. And I don't see what you'll gain by having interrupts
enabled for such short sequences of code on uniprocessor.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/