Re: PATCH: md.c - devfs naming fix.

[Richard Gooch]

Dave Cinege writes:
> This is a multi-part message in MIME format.

Yuk! MIME!

> Changes:
> 	Cleaned a few printk's
> 
> 	Removed a meaningless ifndef.
> 
> 	Moved md= name_to_ kdev_t() processing from md_setup() to
> 	md_setup_drive. Rewrote it and added devfs_find_handle() call
> 	to support devfs names for md=. 
> 
> The devfs_find_handle() code is now redundant in my patch and
> fs/super.c::mount_root(). It probably should be moved directly into
> name_to_kdev_t(), no? If this was done the md= code would have
> worked as is, except for the devfs code choking on the trailing ','
> in the device_names list. (Richard, want to check for this in the
> future?)

What is this patch trying to fix? I've been running devfs with MD
devices for a long time and have no problems. My raidtab lists devfs
device names (in fact, the /dev/sd/* variants created by devfsd) and
it seems to work fine.

> This diff is against md.c in 2.4.4.
> Comments/testing please.

Have you received any other comments? I've not tracked this.

				Regards,

					Richard....
Permanent: [e-mail]
Current:   [e-mail]