Re: PATCH: md.c - devfs naming fix.

[Neil Brown]

On Tuesday July 31, [e-mail] wrote:
> Dave Cinege writes:
> > This is a multi-part message in MIME format.
> 
> Yuk! MIME!
> 
> > Changes:
> > 	Cleaned a few printk's
> > 
> > 	Removed a meaningless ifndef.
> > 
> > 	Moved md= name_to_ kdev_t() processing from md_setup() to
> > 	md_setup_drive. Rewrote it and added devfs_find_handle() call
> > 	to support devfs names for md=. 
> > 
> > The devfs_find_handle() code is now redundant in my patch and
> > fs/super.c::mount_root(). It probably should be moved directly into
> > name_to_kdev_t(), no? If this was done the md= code would have
> > worked as is, except for the devfs code choking on the trailing ','
> > in the device_names list. (Richard, want to check for this in the
> > future?)
> 
> What is this patch trying to fix? I've been running devfs with MD
> devices for a long time and have no problems. My raidtab lists devfs
> device names (in fact, the /dev/sd/* variants created by devfsd) and
> it seems to work fine.

You can start a raid array at boot time with a boot parameter like:

  md=0,/dev/somedisc,/dev/otherdisc,/dev/thatoneoverthere

However, this only worked for device names that were hard coded into
init/main.c.  Devices which only had names in devfs couldn't be
recognised.

The patch delayed the processing of the names in an md= line until
after devfs was initialised, and the made sure that devfs had a chance
to look at them.

> 
> > This diff is against md.c in 2.4.4.
> > Comments/testing please.
> 
> Have you received any other comments? I've not tracked this.

The patch is already in Linus' tree.

NeilBrown

> 
> 				Regards,
> 
> 					Richard....
> Permanent: [e-mail]
> Current:   [e-mail]
> -
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to [e-mail]