Re: 2.5.5[01]]: Xircom Cardbus broken (PCI resource collisions)

--==_Exmh_1952560008P
Content-Type: text/plain; charset=us-ascii

On Fri, 13 Dec 2002 17:33:00 +0100, Petr Konecny <[e-mail]>  said:

>  Valdis> I see why the if/continue was added - you don't want to be
>  Valdis> calling device_register()/pci_insert_device() if
>  Valdis> pci_enable_device() loses.  I don't see why 2.5.50 moved the
>  Valdis> code up after pci_setup_device(). There's an outside chance
>  Valdis> that the concept of moving the call was correct, but that it
>  Valdis> should have been moved to between the calls to
>  Valdis> pci_assign_resource() and pci_readb().  If that's the case,
>  Valdis> then you're correct as well....
> I can confirm that this indeed works. I moved the two lines before
> pci_readb and the card works (every character you now read went through
> it). Who shall submit a patch to Linus ?

The problem is this from the 2.5.50 Changelog that Linus posted:

Dave Jones <[e-mail]>:
...
  o make cardbus PCI enable earlier

I'm willing to submit a patch, but I think Dave has to make the call whether
it should be backed out entirely, or moved after pci_assign_resource().
I certainly don't understand the code *or* PCI well enough to decide between
those two option...

/Valdis

--==_Exmh_1952560008P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQE9+haBcC3lWbTT17ARAuFbAJ4wXQaX0gQSdtIDC0bLyjdtpTan5QCg3K9R
ZYn1ZcmNFCdc68kLfCtgm34=
=fgAB
-----END PGP SIGNATURE-----

--==_Exmh_1952560008P--