Re: 2.5.5[01]]: Xircom Cardbus broken (PCI resource collisions)

[Dave Jones]

On Fri, Dec 13, 2002 at 12:18:58PM -0500, [e-mail] wrote:
 > On Fri, 13 Dec 2002 17:33:00 +0100, Petr Konecny <[e-mail]>  said:
 > > > I see why the if/continue was added - you don't want to be
 > > > calling device_register()/pci_insert_device() if
 > > > pci_enable_device() loses.  I don't see why 2.5.50 moved the
 > > > code up after pci_setup_device(). There's an outside chance
 > > > that the concept of moving the call was correct, but that it
 > > > should have been moved to between the calls to
 > > > pci_assign_resource() and pci_readb().  If that's the case,
 > > > then you're correct as well....
 > > I can confirm that this indeed works. I moved the two lines before
 > > pci_readb and the card works (every character you now read went through
 > > it). Who shall submit a patch to Linus ?
 > 
 > The problem is this from the 2.5.50 Changelog that Linus posted:
 > 
 > Dave Jones <[e-mail]>:
 > ...
 >   o make cardbus PCI enable earlier
 > 
 > I'm willing to submit a patch, but I think Dave has to make the call whether
 > it should be backed out entirely, or moved after pci_assign_resource().
 > I certainly don't understand the code *or* PCI well enough to decide between
 > those two option...

It's my understanding that pci_enable_device() *must* be called
before we fiddle with dev->resource, dev->irq and the like.

		Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs