Re: 2.4.21-pre4 comparison bugs

Alan Cox (alan@lxorguk.ukuu.org.uk)
09 Feb 2003 00:58:40 +0000

On Sat, 2003-02-08 at 17:18, Oleg Drokin wrote:
> - if((autodma = ide_setup_pci_controller(dev, d, noisy, &tried_config)) < 0)
> + if((int)(autodma = ide_setup_pci_controller(dev, d, noisy, &tried_config)) < 0)
> return index;

Well caught. I don't like your fix. I'd prefer to do the job properly
and either make it return a signed value or split error/value reporting
in these various cases.

I'll fix them for the next -ac

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/