Re: 2.4.21-pre4 comparison bugs (More of those)

Alan Cox (alan@lxorguk.ukuu.org.uk)
09 Feb 2003 22:01:30 +0000


On Sun, 2003-02-09 at 17:53, Oleg Drokin wrote:
> This time I changed the type of variable to signed type whenever
> I felt it was appropriate.
> When I was not sure (or unsigned type was in some commonly used
> structure), I still used a cast just to highlight a problem, so that someone
> more knowledgeable created better fix.
> See the patch.
> Mostly we do incorrect stuff on errors. Sigh, nobody likes errors ;)

Hiding them is even worse than having them there visible and unfixed.
Changing the sign on stuff holding physical addresses is actually
introducing real bugs

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/