Re: [PATCH] ALSA update [6/10] - 2002/07/20

Arjan van de Ven (arjanv@fenrus.demon.nl)
29 Sep 2002 21:12:23 +0200


--=-Cd/yAp59i6q+E+SqwRJc
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sun, 2002-09-29 at 20:51, Jaroslav Kysela wrote:
> + sgbuf =3D snd_magic_cast(snd_pcm_sgbuf_t, substream->dma_private, retur=
n -EINVAL);

hummmm magic casts?? why ?

> + ptr =3D snd_malloc_pci_pages(sgbuf->pci, PAGE_SIZE, &addr);

what is wrong with the PCI DMA API that makes ALSA wants a private
interface/implementation ?

> EXPORT_SYMBOL(snd_wrapper_kmalloc);
> EXPORT_SYMBOL(snd_wrapper_kfree);
> +EXPORT_SYMBOL(snd_wrapper_vmalloc);
> +EXPORT_SYMBOL(snd_wrapper_vfree);

why do you need a wrapper for vfree?=20

--=-Cd/yAp59i6q+E+SqwRJc
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQA9l1CXxULwo51rQBIRAqwiAJwJly9DE66y4muuZnrbgmsPbZf78ACglbo3
v1uQruhq52jbXdp8sCYVV5M=
=sEN9
-----END PGP SIGNATURE-----

--=-Cd/yAp59i6q+E+SqwRJc--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/